verbb / xero

Other
1 stars 6 forks source link

Bug: Created Invoice in Xero not applying the correct product tax rate from Craft Commerce #8

Open acantes opened 3 years ago

acantes commented 3 years ago

Hi Josh, as requested, here's the issue my client is having.

My client's Craft Commerce store has products with different TAX categories/rates. Basically as a UK shop products are either 20% VAT or 0% VAT.

Currently, if an order contains line item products with different tax rates then these are ignored when the order details are passed to Xero. Even if the tax rate should be 0% VAT in the Craft Commerce product then it's appearing in Xero as "20% (VAT on Income)" which I presume means that it's just using Craft's default tax category/rate which is 20% VAT in the case of this website.

Attached is my settings for the Xero plugin and then screenshots of an example Craft order and it's corresponding Xero invoice.

The knock-on effect of this is that Xero seems to keep the order total correct, but then creates a new rounding line on the invoice to accomplish this. The client now has incorrect tax records for accounting purposes, so this is a big issue for them.

craft-order

xero-invoice

xero-settings

Happy to send over more details on request. Thanks as always.

Craft v3.6.11.1 Xero plugin v1.0.4.1

acantes commented 3 years ago

Hi Josh, just checking in as I've not had a reply to this issue. Are you stilla ctively developing this plugin?

moacode commented 3 years ago

😅 apologies—I've had a lot on my plate as of late. I will make some time over the next few days to look at these issues. Please bump me again if I go quiet!

On Wed, Aug 4, 2021 at 9:57 PM acantes @.***> wrote:

Hi Josh, just checking in as I've not had a reply to this issue. Are you stilla ctively developing this plugin?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thejoshsmith/commerce-xero/issues/8#issuecomment-892527080, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKCPKZYG3ZCGQYD4MVNVVLT3EFIFANCNFSM45EITTEQ .

acantes commented 3 years ago

Thanks Josh, appreciate it.