NWC does not work and webln issues

verbiricha / habla.news

GNU General Public License v3.0

46 stars 21 forks source link

NWC does not work and webln issues #112

Closed rolznz closed 11 months ago

rolznz commented 11 months ago

Bitcoin connect is only imported if webln already exists, this is never true on mobile - see https://github.com/verbiricha/habla.news/blob/main/src/hooks/useWebln.js#L10 - I see there is an issue with SSR and it breaking because window does not exist. I'll have a look.
webln.enabled is checked at https://github.com/verbiricha/habla.news/blob/main/src/components/ZapModal.tsx - enabled is an internal variable (and does not exist on some webln instances, like bitcoin connect NWC). The ~~standard~~recommended method is to try to await webln.enable(), and if it fails (an exception is thrown) then use the fallback QR / open wallet approach.
Typings could be added with https://www.npmjs.com/package/@webbtc/webln-types

Reference: https://webln.guide/

nicky-dev commented 11 months ago

I got this error in iOS PWA

rolznz commented 11 months ago

@nicky-dev what iOS version are you using?

nicky-dev commented 11 months ago

@nicky-dev what iOS version are you using?

iOS Version: 16.7

rolznz commented 11 months ago

Hmm. It works fine for me on 16.3.1. That is just when you connected to your wallet, right?

I'll create an issue and let you know if I can reproduce it or find a fix.

rolznz commented 11 months ago

@nicky-dev does it also happen when you access the site from Safari rather than with the PWA?

nicky-dev commented 11 months ago

It happens when using the PWA.

rolznz commented 11 months ago

@nicky-dev did you install the PWA from a secure HTTPS context? like a ngrok https:// URL?

I have the same issue when I save the PWA for http://localhost:3000 (on iOS. On desktop it works fine)

rolznz commented 11 months ago

I made a PR for the fixes here: https://github.com/verbiricha/habla.news/pull/114

nicky-dev commented 11 months ago

@nicky-dev did you install the PWA from a secure HTTPS context? like a ngrok https:// URL?

I have the same issue when I save the PWA for http://localhost:3000 (on iOS. On desktop it works fine)

Thanks @rolznz, It work from ngrok https.