search

verbose / readme-badges

Readme badge templates.
MIT License
5 stars 10 forks source link

JS Standard #11

Closed mightyiam closed 9 years ago

mightyiam commented 9 years ago

Fulfills #10.

Hrm... Shields.io provides several styles (see "Styles" section).

Can we support that?

mightyiam commented 9 years ago

@feross FYI

jonschlinkert commented 9 years ago

thanks!

jonschlinkert commented 9 years ago

oops, forgot to replace your username the templates. no worries I'll do that now

jonschlinkert commented 9 years ago

nvm I don't think these need username, I'm reading over shields.io now

mightyiam commented 9 years ago

Right, these don't have usernames.

mightyiam commented 9 years ago

Thank you.

jonschlinkert commented 9 years ago

got it, looks good, thanks!

jonschlinkert commented 9 years ago

published 0.1.2, a patch bump since this just adds templates and doesn't break anything.

mightyiam commented 9 years ago

published 0.1.2, a patch bump since this just adds templates and doesn't break anything.

Digressing here.

According to semver that should bump the minor version, because it is a feature.

The patch is for bug fixes.

jonschlinkert commented 9 years ago

According to semver that should bump the minor version, because it is a feature.

Not really, it's not a new feature - more specifically it's not new "functionality", which is what semver specifies. Just new templates for the badge() helper to use. I can see how we could make a case that adding new templates would be "new functionality", but given that the templates themselves don't have any variables, there is nothing in them that can break this library or, when explicitly defined by a user, that could break the badge() helper. The badge helper does not need to change to leverage the helpers, and nothing was fixed either.

Anyway, moving away from semver philosophy, just being pragmatic, if we do a minor bump you wouldn't be able to use this until I bump this in verb and verb-cli then publish new versions of both.

mightyiam commented 9 years ago

if we do a minor bump you wouldn't be able to use this until I bump this in verb and verb-cli then publish new versions of both.

I would imagine that verb and verb, for example, v0.1.1 should peerDepend on verb-readme-badges, v^0.1.1. In that case, bumping the MINOR shouldn't prevent verb from using verb-readme-badges.

Isn't it like this?

jonschlinkert commented 9 years ago

Hmm, I might have used peerDepencies for the templates a while back. I'll look into it again. thanks