search

vercel / async-retry

Retrying made simple, easy and async
https://npmjs.com/async-retry
MIT License
1.85k stars 53 forks source link

[FIX]: Make parameter opts optional again. #66

Closed yeldiRium closed 4 years ago

yeldiRium commented 4 years ago

Hi everyone,

with the release of v1.3.0 the parameter opts became mandatory because of this block. Since it checks the original opts instead of the modified options, not passing opts breaks retry.

To commit this change I had to disable the commit hook, since the var declaration not at the top of the function goes against the linter rules, but I thought I should let you decide on how to deal with your code style.

This PR will still break your CI pipeline because of the linter, but the unit tests now pass again.

Kind regards, yeldiR

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click on the icon next to each commit.

vercel[bot] commented 4 years ago

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `scripts` property.
lucleray commented 4 years ago

Thanks for reporting and fixing @yeldiRium!

lucleray commented 4 years ago

Release in 1.3.1.

yeldiRium commented 4 years ago

Thanks for the quick reply and release of a new version :)