search

vercel / commerce

Next.js Commerce
https://demo.vercel.store
MIT License
10.54k stars 3.88k forks source link

Add Ecwid by Lightspeed provider #1304

Closed meteor-ec closed 1 month ago

meteor-ec commented 4 months ago

Hi there!

This is Ilnur from the Ecwid by Lightspeed team.

We have added our service as a provider. Please add us to the list.

Thanks a lot!

vercel[bot] commented 4 months ago

@meteor-ec is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

manovotny commented 3 months ago

Hey @meteor-ec! This is a good start!

I looked at the changes you made and I have some questions.

  1. The checkout page is very slow and the code for the page is interesting. Is this what you expect users to do? Feels like this could be improved.
  2. Why are you adding <link rel="prefetch" href="/api/revalidate" as="fetch" /> to the <head> in the Layout? What are you trying to do or what does this achieve?
  3. image: product.featuredImage?.url in productJsonLd could produce an invalid schema as it could be undefined. It's be better to change the the model to always return a url, and in lib/ecwid return a default images if there isn't a featured image.
  4. The changes to CartModal for not displaying on the checkout page could be improved. Rearranging the structure of your Layouts or using multiple root Layouts would be the better solve here.
meteor-ec commented 2 months ago

Hi @manovotny!

Thanks for your review and feedback! I was on vacation and couldn't respond immediately :palm_tree:

So I've made changes to points 2-4, please take a look.

On point 1, we don't have an external url for the checkout page, like Shopify for example. So we embed the checkout into the page. There are plans to improve this place, but for now I decided to leave it as it is.

manovotny commented 1 month ago

@meteor-ec thanks for making those adjustments.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:31pm
meteor-ec commented 1 month ago

Thank you so much @manovotny! :handshake: