vercel / commerce

Next.js Commerce
https://demo.vercel.store
MIT License
11.55k stars 4.27k forks source link

Github Action integration / prettier finds issues in master #878

Closed diimpp closed 1 year ago

diimpp commented 2 years ago

Describe the feature you'd like to request

Hey guys,

any reason not to use github actions for lint,build,test for PRs?

I've just executed turbo run prettier-fix and getting quite the amount of fixes in master. image

List of suggestions ``` modified: packages/commercejs/src/checkout/use-checkout.tsx modified: packages/commercejs/src/index.tsx modified: packages/kibocommerce/README.md modified: packages/kibocommerce/codegen.json modified: packages/kibocommerce/schema.d.ts modified: packages/kibocommerce/src/api/fragments/cartItemDetails.ts modified: packages/kibocommerce/src/api/fragments/category.ts modified: packages/kibocommerce/src/api/fragments/product.ts modified: packages/kibocommerce/src/api/fragments/productDetails.ts modified: packages/kibocommerce/src/api/fragments/search.ts modified: packages/kibocommerce/src/api/mutations/addItemToWishlist-mutation.ts modified: packages/kibocommerce/src/api/mutations/create-wishlist-mutation.ts modified: packages/kibocommerce/src/api/mutations/login-mutation.ts modified: packages/kibocommerce/src/api/mutations/removeItemFromCart-mutation.ts modified: packages/kibocommerce/src/api/mutations/removeItemFromWishlist-mutation.ts modified: packages/kibocommerce/src/api/mutations/signup-mutation.ts modified: packages/kibocommerce/src/api/mutations/updateCartItemQuantity-mutation.ts modified: packages/kibocommerce/src/api/operations/get-all-product-paths.ts modified: packages/kibocommerce/src/api/operations/get-product.ts modified: packages/kibocommerce/src/api/queries/get-all-pages-query.ts modified: packages/kibocommerce/src/api/queries/get-all-products-query.ts modified: packages/kibocommerce/src/api/queries/get-cart-query.ts modified: packages/kibocommerce/src/api/queries/get-categories-tree-query.ts modified: packages/kibocommerce/src/api/queries/get-customer-account-query.ts modified: packages/kibocommerce/src/api/queries/get-customer-wishlist-query.ts modified: packages/kibocommerce/src/api/queries/get-page-query.ts modified: packages/kibocommerce/src/api/queries/get-product-query.ts modified: packages/kibocommerce/src/api/queries/product-search-query.ts modified: packages/kibocommerce/src/checkout/use-checkout.tsx modified: packages/kibocommerce/src/commerce.config.json modified: packages/kibocommerce/src/customer/address/use-add-item.tsx modified: packages/kibocommerce/src/customer/card/use-add-item.tsx modified: packages/kibocommerce/src/index.tsx modified: packages/kibocommerce/src/lib/get-cookie-expiration-date.ts modified: packages/kibocommerce/src/lib/prepare-set-cookie.ts modified: packages/kibocommerce/src/lib/product-search-vars.ts modified: packages/kibocommerce/src/next.config.cjs modified: packages/kibocommerce/src/provider.ts modified: packages/ordercloud/src/api/operations/get-site-info.ts modified: packages/ordercloud/src/customer/use-customer.tsx modified: packages/ordercloud/src/index.tsx modified: packages/saleor/schema.d.ts modified: packages/saleor/schema.graphql modified: packages/saleor/src/api/index.ts modified: packages/saleor/src/api/operations/get-site-info.ts modified: packages/saleor/src/auth/use-login.tsx modified: packages/saleor/src/auth/use-logout.tsx modified: packages/saleor/src/auth/use-signup.tsx modified: packages/saleor/src/cart/use-add-item.tsx modified: packages/saleor/src/checkout/use-checkout.tsx modified: packages/saleor/src/customer/address/use-add-item.tsx modified: packages/saleor/src/customer/card/use-add-item.tsx modified: packages/saleor/src/customer/use-customer.tsx modified: packages/saleor/src/index.tsx modified: packages/saleor/src/utils/checkout-attach.ts modified: packages/saleor/src/utils/customer-token.ts modified: packages/saleor/src/utils/get-sort-variables.ts modified: packages/saleor/src/utils/mutations/checkout-create.ts modified: packages/saleor/src/utils/mutations/checkout-line-add.ts modified: packages/saleor/src/utils/mutations/checkout-line-update.ts modified: packages/saleor/src/utils/throw-user-errors.ts modified: packages/swell/schema.d.ts modified: packages/taskr-swc/.prettierrc modified: packages/vendure/schema.d.ts modified: packages/vendure/src/api/endpoints/index.ts modified: packages/vendure/src/next.config.cjs ```

Describe the solution you'd like

Use automations to catch issues early.

Describe alternatives you've considered

Use other preferred CI platform.

cond0r commented 2 years ago

Thank you for the recommendation, this will be considered when reaching the phase of stable & non-breaking changes phase.

leerob commented 1 year ago

Hey there! Thank you for your contribution. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: https://github.com/vercel/commerce/pull/966