Issues spotted at GF onboarding time revision

vercel / geist-font

https://vercel.com/font

SIL Open Font License 1.1

2.38k stars 64 forks source link

Issues spotted at GF onboarding time revision #132

Open vv-monsalve opened 6 days ago

vv-monsalve commented 6 days ago

Font Name (Geist Sans/Geist Mono):

[x] Geist Sans
[x] Geist Mono

During the last onboarding review, my colleague @emmamarichal and I noticed some areas that need improvement.

Cyrillic

While Cyrillic is not among the base standard requirements for submitted fonts in GF, please consider making the following adjustments.

Please review the connection (the descender is not well attached) and the vertical position of the following glyphs ҖҚҢҲҶҗқңҳҷ:
The bar could be better centered:

Kerning

The Cyrillic kerning could be improved:

vv-monsalve commented 6 days ago

Monospace issues

[ ] Most ligatures tested are working ok but
- <---
- ###

[x] Alignment issue The glyph could be decomposed as in the proportional Geist. It's highly suggested not to combine components with paths.

vv-monsalve commented 6 days ago

Small adjustments

[x] Please review the currency position throughout the masters,
[x] The comma could be centered with the T stem:

vv-monsalve commented 6 days ago

Interpolation

[x] uhungarumlaut is not using the right component

guidoferreyra commented 6 days ago

Oh I did the same fixes, we commited almost at the same time 🤣

Anyway, the cyrillic was not reviewed and requires a complete overhaul, nevertheless, I made the changes you asked.
The two missing coding ligatures are left out from the feature because I couldn’t find evidence that those are used. Perhaps the glyphs should be not exported.

vv-monsalve commented 6 days ago

Oh I did the same fixes, we commited almost at the same time 🤣

I decided to make a PR to speed up 🫠

couldn’t find evidence that those are used. Perhaps the glyphs should be not exported.

Yes, please; in that case, it is better not to export them.

vv-monsalve commented 5 days ago

@guidoferreyra Please bring the additional changes I was including in the PR: the license URL change in the font info and the adjustment to: softsign-cy and yeru-cy

vv-monsalve commented 2 days ago

Perhaps the glyphs should be not exported.

Please remember to make the nonworking ligatures non-export.

guidoferreyra commented 2 days ago

Somehow I missed your comments on this issue. I will make these fixes asap.