vercel / geist-font

https://vercel.com/font
SIL Open Font License 1.1
2.13k stars 54 forks source link

Add Geist Mono to Nerd Fonts #18

Closed QuiiBz closed 7 months ago

QuiiBz commented 8 months ago

Nerd Fonts is heavily used to generate patched programming fonts with many useful icons. After reading the license, I think it's something that's permitted and would benefit many folks.

I made a PR upstream to the Nerd Fonts repo to add & patch Geist Mono: https://github.com/ryanoasis/nerd-fonts/pull/1398

JohnPhamous commented 8 months ago

Thank you! How can we help?

QuiiBz commented 8 months ago

I think we just have to wait for a new review on https://github.com/ryanoasis/nerd-fonts/pull/1398 - Finii also mentioned the 0 vs O differentiation issue, but that doesn't seem to be a blocker.

I opened this issue to have a link back from the upstream PR on Nerd Fonts' repo, there is no precise work needed here.

daiyam commented 8 months ago

The 0 and O differentiation issue is being discuss at https://github.com/vercel/geist-font/issues/23

JohnPhamous commented 8 months ago

We will be making a new release soon with the stylized 0 enabled by default.

JohnPhamous commented 8 months ago

Fixed and available in the 1.0.1 release on GitHub and on npm.

QuiiBz commented 8 months ago

Amazing, I've just updated the upstream Nerd Fonts PR to use 1.0.1.

emapeire commented 8 months ago

Let's rock guys! Thanks 🤩

QuiiBz commented 7 months ago

Closing as it has been released in Nerd Fonts 3.1.0: https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.1.0