vercel / geist-font

https://vercel.com/font
SIL Open Font License 1.1
2.13k stars 54 forks source link

Request italic font files #42

Closed jessypouliot98 closed 8 months ago

jessypouliot98 commented 8 months ago

Font Name (Geist Sans/Geist Mono):

Description of the Issue: I want to use the Geist Sans font in react-pdf. My use case requires italics to enable them I need to register the font file which it doesn't exist. My current fallback is to define the italic variant as a non-italic variant, otherwise the pdf generation fails.

Screenshots:

    Pdf.Font.register({
      family: "Geist",
      fonts: [
        { src: path.resolve(fontPath, "Geist-Regular.woff2"), fontWeight: "normal" },
        { src: path.resolve(fontPath, "Geist-Regular.woff2"), fontWeight: "normal", fontStyle: "italic" }, // Not actually italic
        { src: path.resolve(fontPath, "Geist-Bold.woff2"), fontWeight: "bold" },
        { src: path.resolve(fontPath, "Geist-Bold.woff2"), fontWeight: "bold", fontStyle: "italic" },  // Not actually italic
      ]
    });

Environment (please complete the following information):

JohnPhamous commented 8 months ago

Thank you for the request. Going to merge this with #29.

ihfandicahyo commented 7 months ago

Wait, hello. Does now is support italic for Geist-Sans? I use for android and missing italic style or i have a skill problem?