Middle-clicking on selected text should paste it to the current input

vercel / hyper

A terminal built on web technologies

https://hyper.is

MIT License

43.27k stars 3.52k forks source link

Middle-clicking on selected text should paste it to the current input #1023

Open perry-mitchell opened 7 years ago

perry-mitchell commented 7 years ago

OS version and name: Ubuntu 16.04
Hyper.app version: 0.8.3 -> 1.0.0
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/perry-mitchell/e524335b722839b55ea6d09140648bc3
Relevent information from devtools: NA
The issue is reproducible in vanilla Hyper.app: Is vanilla

Issue

In other terminals middle-clicking pastes selected content, wherever you click in the terminal. Hyper will paste only if the middle click does not occur on top of the selected text:

When middle-clicking on the text itself, nothing happens.

jamo commented 7 years ago

Does the normal paste command (cmd+v etc.) work -- it might require setting copyOnSelect: true in ~/.hyper.js

kleinfreund commented 7 years ago

@jamo When hovering over selected text, pressing the mouse wheel does nothing no matter what copyOnSelect is set to.

However, CtrlShiftV works while hovering over selected text when copyOnSelect is set to true, not when set to false.

(I’m on Ubuntu 16.04, too. Same Hyper version)

perry-mitchell commented 7 years ago

This also occurs when middle-clicking anywhere on the same line, even if it's not exactly on the text.

ppot commented 7 years ago

@perry-mitchell I will do a PR you will be able to test it when made

working-name commented 7 years ago

Any update on this? Middle mouse click for paste is kinda staple in most terminals... got used to its convenience, hoping I can recreate it here too. Thank you!