search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.19k stars 3.5k forks source link

Auto-update if all windows closed #1325

Open leo opened 7 years ago

leo commented 7 years ago

IMO, we should just restart automatically after downloading an update if no Hyper window is open.

rauchg commented 7 years ago

This is really clever

einfallstoll commented 7 years ago

As long as there is a notice I'm fine with that.

albinekb commented 7 years ago

I wouldn't expect that to happen...

pablopunk commented 7 years ago

From the electron auto-updater docs:

Note: autoUpdater.quitAndInstall() will close all application windows first and only emit before-quit event on app after that. This is different from the normal quit event sequence.

If there is no window open, shouldn't quitAndInstall() just restart it? I mean, I would assume that that's the expected behavior, isn't it working like that right now?

ppot commented 7 years ago

I prefer the macOS way. Give user the ability to update when they want.

rauchg commented 7 years ago

I like the Chrome way. Always run the latest, the least you bother the user the better.

pablopunk commented 7 years ago

I like the Chrome way. Always run the latest, the least you bother the user the better.

Thumbs up for that 🙌🏻

IMO for patches or even minor versions it should be automatic.

rauchg commented 7 years ago

Yep, in the case of no terminal sessions being open, for all cases I think

AlbertoElias commented 7 years ago

That would be great. How does the updating process work currently? Is it manual? I'm on Windows 10

jhonnymoreira commented 7 years ago

@rauchg is this issue valid yet? I started using Hyper a few days ago and I would like to contribute.

leo commented 7 years ago

Yep, I'd say we're happy to accept a PR for it! 😊

jhonnymoreira commented 7 years ago

thanks, @leo! Expect a PR soon. [=

Stanzilla commented 6 years ago

https://github.com/zeit/hyper/pull/2515