vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.47k stars 3.52k forks source link

Ugly shadow on menubar reveal in fullscreen(macOS) #1386

Open shreyasminocha opened 7 years ago

shreyasminocha commented 7 years ago

Issue

I typically have at least one terminal window running in full screen on my system. I recently noticed that one revealing the menu bar when in full screen, there is an ugly shadow-like thing that appears under the menu bar. Following are few screenshots that demonstrate my issue.

screen shot 2017-01-11 at 15 00 05

It can be seen more clearly when I focus on the entire window in devtools.

screen shot 2017-01-11 at 15 08 20

See that little shadow below the window controls? That's what I'm talking about

webb04 commented 7 years ago

This can be fixed by setting titleBarStyle: hidden rather than titleBarStyle: hidden-inset in Index.js. But would require realigning the tab names with the window controls.