search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.23k stars 3.51k forks source link

Chinese Language support please #2014

Closed ShineSmile closed 6 years ago

ShineSmile commented 7 years ago

Input Chinese character with Sougou Pinyin IME doesn't work well. The width of Chinese character displayed is not enough.

Hyper 1.3.3 Electron 1.4.16 win32 x64 10.0.15063

Sanster commented 7 years ago

@ShineSmile Check https://github.com/zeit/hyper/issues/2012

 termCSS: '.wc-node{width:16px !important}',
ShineSmile commented 7 years ago

@Sanster Thanks. The problem of display has been resolved.

But I still can't input Chinese character with IME. Nether Sougou Pinyin IME nor Microsoft Pinyin works.

Hypnoes commented 7 years ago

And also in non-English mode, you should type twice to input one character. 😆

hunnble commented 7 years ago

Also, after pasting some Chinese characters, I found that these characters were rendered twice

yuezy3 commented 7 years ago

Well, I think this is very serious issue. This app can't display (properly) and input Unicode Char??!!

albinekb commented 7 years ago

@yuezy3 the problem is, to fully support chinese and other double-width languages we need to have someone that knows chinese and can read it, It's really hard for me or someone else that doesn't know anything about this language to fix all the things that are wrong, and at the same time make sure that we don't accidentally break anything, as we can't know how it's supposed to be.

Plus the fact that no one of our current maintainers are using or needing chinese in our terminal, means we don't put focus on this.

TL:DR To fully support chinese, we need a chinese maintainer...

Piping commented 6 years ago

Hi, I would like to take a look on the code itself. Any guide for implementing double-width characters?

chabou commented 6 years ago

I think that this issue has been fixed in our canary (upcoming v2). @Piping This is handled directly by xtermjs: https://github.com/xtermjs/xterm.js/