Zoom In / Out while pressing Ctrl + Mouse Wheel [up/down]

reyronald commented 6 years ago

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Microsoft Windows [Version 10.0.15063]
Hyper.app version: Hyper 1.4.8 (stable)
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/reyronald/895879a5be0b496a7f73e0527cab8f0b
The issue is reproducible in vanilla Hyper.app: Yes

Issue

It is common for many apps, including browsers, to be able to Zoom In / Out the contents (or increase/decrease the font size) by pressing Ctrl while scrolling the Mouse Wheel up and down.

I searched through issues related to the Zoom functionality but couldn't find a particular reason why this isn't possible with Hyper, or maybe it is but it's not working for me? Is this something that could be added?

jongalloway commented 6 years ago

I looked at this a bit in case it was easy. The keyboard shortcuts are configured using Mousetrap, which doesn't have support for mouse events (including WheelEvent) so it's not as trivial as I was hoping.

There are zoom event hotkeys in the meantime.

reyronald commented 6 years ago

Hey @jongalloway , thanks for taking the time to check it out. My main concern was that it was left out intentionally for some reason, technical or not, so I didn't want to invest time investigating it myself without asking first.

I'll see if I have some time to explore and come up with an viable approach to discuss, and we'll see from there.

vercel / hyper

Zoom In / Out while pressing Ctrl + Mouse Wheel [up/down] #2495

Issue