Update prompt links to json instead of GitHub releases

vercel / hyper

A terminal built on web technologies

https://hyper.is

MIT License

43.25k stars 3.51k forks source link

Update prompt links to json instead of GitHub releases #2621

Open Stanzilla opened 6 years ago

Stanzilla commented 6 years ago

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10 1709
Hyper.app version: Canary.10
Link of a Gist with the contents of your .hyper.js:
Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
The issue is reproducible in vanilla Hyper.app:

Issue

On Windows, the update prompt links to the json blob at https://releases-canary.hyper.is/update/win32/2.0.0-canary.10 instead of the GitHub releases page. Looking at https://github.com/zeit/hyper/blob/canary/app/updater.js#L72 we might end up with updateUrl instead of releaseUrl?

Stanzilla commented 6 years ago

cc @leo

Stanzilla commented 6 years ago

Should be fixed by https://github.com/zeit/hyper/commit/dc3155f190d7f72540c85c860b6f715a4befad44

Stanzilla commented 6 years ago

The link now is https://github.com/zeit/hyper/releases/tag/2.0.0-canary13 instead of https://github.com/zeit/hyper/releases/tag/2.0.0-canary.13 notice the missing period.

@ppot

Stanzilla commented 6 years ago

@leo

leo commented 6 years ago

So, what exactly is the problem again?

Stanzilla commented 6 years ago

The link to the update notes in the "new version is ready" notification is https://github.com/zeit/hyper/releases/tag/2.0.0-canary13 instead of https://github.com/zeit/hyper/releases/tag/2.0.0-canary.13 notice the missing period.

leo commented 6 years ago

@Stanzilla And that's only on Windows, right? Probably because Squirrel for Windows (the auto update software) is using the app's version, which is missing that dot I think.

So let's just somehow add it?

Stanzilla commented 6 years ago

I've only seen the problem on Windows, yeah.