vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.27k stars 3.52k forks source link

Poor canvas performance (drawImage) probably caused by electron #2790

Open TickleThePanda opened 6 years ago

TickleThePanda commented 6 years ago

Issue

Poor performance probably due to electron bug: electron/electron#11051

bgw commented 6 years ago

Yep. The electron issues probably don't help, but it's slow on up-to-date versions of Chrome too.

Xterm.js often draws much more to the screen than it needs to, mostly because of some complications with overlapping wide characters. I'm working towards fixing this, and some other related performance issues, so the idea is that while it'll still be possible to end up with 160 ms frames, they'll be much less common.

I think if we want to completely eliminate these kinds of performance issues, we'll need to use WebGL, since that'll let us fill the entire screen with one or two draw calls. However, that's a lot more complicated, so I'm not interested in working on it the moment.

Stanzilla commented 5 years ago

https://bugs.chromium.org/p/chromium/issues/detail?id=683994