Alpha values less than 1 do not display properly

vercel / hyper

A terminal built on web technologies

https://hyper.is

MIT License

43.28k stars 3.52k forks source link

Alpha values less than 1 do not display properly #2847

Open nikhildhawan117 opened 6 years ago

nikhildhawan117 commented 6 years ago

[x ] I am on the latest Hyper.app version
[ x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Mac OS 10.12.6
Hyper.app version: 2.0.0
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/nikhildhawan117/2aa305f609b406c66aa4f58b47cdbe54
Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

After the new update, overtime the alpha value is changed to be less than 1, the hyper terminal displays the new color value correctly once the .hyper.js is saved, but once hyper is quit and reopened, the terminal displays a much more transparent alpha. This was never an issue in the previous version.

tmvst commented 6 years ago

I think I might be experiencing this same problem with Verminal theme. Terminal background in this theme is partly transparent with glass effect, but the transparency is reasonable only after installing the theme. After I open new Hyper window or restart the app, the transparency freaks out. Screenshot: http://files.tmv.st/qxVV (top one is a new window, bottom is right after installing the theme)

One thing I noticed when checking for console errors (there are none), after I open and close the console, background transparency switches back to normal. What is going on?

I'm on Mac OS 10.13.4 with freshly updated Hyper 2.0

albinekb commented 6 years ago

Interesting, thanks for reporting this and that image helps a lot.

dharmavagabond commented 6 years ago

The issue also happens when loading the config file but it resets back to normal by opening and closing the dev tools: https://github.com/defringe/verminal/issues/6.

IanMitchell commented 6 years ago

I'm getting reports of this too from users of my theme

EDIT: Looks like maybe the selector gets overridden? On the xterm-viewport class I'm seeing this CSS:

.xterm .xterm-viewport {
  background-color: rgba(0, 0, 0, 0.8);
  ...
}

which is being overridden by inline styling - style="background-color: transparent;". It isn't the full window, but it's the only area I'm able to see the background-color attribute applied

mbugbee commented 6 years ago

I'm having this same issue on OSX 10.13.5, using the Hyper Material Theme.