vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.2k stars 3.51k forks source link

Menu->Edit->Preferences... does nothing #3007

Open parsyval opened 6 years ago

parsyval commented 6 years ago

Issue

When navigating the menus, when I click on Edit -> Preferences..., nothing happens.

When debugging the code, it goes to app/config/open.js (line 65). Yes = true cfgPath = "C:\Users{user}.hyper.js"

sanjibukai commented 5 years ago

I have the same issue.. I'm on manjaro (arch) linux and what I go to Edit->Preferences nothing happen except I got a notification message stating that: Mount/Unmount /home/username/.hyper.js is not a supported file type` Not sure what cause this error and what should happen instead, does an editor should open?

Also it seems that you are experiencing this on the same release version (2.1.0 canary).. Isn't there any update since 6 months?

j-f1 commented 5 years ago

It should open an editor with .hyper.js.

sanjibukai commented 5 years ago

So I guess that the settings are in JSON so I can simply open and edit it outside..

j-f1 commented 5 years ago

Sort of — it’s kind of like a Node module with module.exports set to the config object. However, you can’t require() anything, and the module.exports = declaration has to be the first statement in the file. Other than that, it’s just a JS object.

notasausage commented 5 years ago

It should open an editor with .hyper.js.

On macOS, for some reason all .js files were defaulting to opening in a Fluid app instance. So everytime I tried to to Menu > Edit > Preferences in Hyper, it would just give me an odd message and open that Fluid instance.

To fix this I found a .js file on my laptop, did a Get Info (COMMAND i), expanded the "Open with..." panel, chose my text editor (Atom), and clicked the "Change All..." button so that all .js files defaulted to opening in Atom (which I wanted regardless).

That said, Hyper should do a better job of handling this issue, since I'm a new user and didn't know it was trying to open a .js file for me to edit rather than the usual macOS preferences panel for an app.