vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.21k stars 3.51k forks source link

cursorAccentColor not updating or taking effect #3016

Open joemottershaw opened 6 years ago

joemottershaw commented 6 years ago

Changing default cursorAccentColor from #000 to anything else doesn't seem to take effect, the text underneath the block cursor continues to stay the default black. I've also tried with various themes, all with different cursorAccentColors declared in their theme settings, but all continue to display in black.

jsejcksn commented 4 years ago

Here is a screenshot to illustrate this issue, and to show that the cause seems to also affect selected text. Additionally, note the peculiar anti-aliasing of the selected text:

hyper-selection-black-aliasing
Software Version
OS macOS 10.15.1
Hyper 3.0.2
.hyper.js ```js // Future versions of Hyper may add additional config options, // which will not automatically be merged into this file. // See https://hyper.is#cfg for all currently supported options. module.exports = { config: { // choose either `'stable'` for receiving highly polished, // or `'canary'` for less polished but more frequent updates updateChannel: 'stable', // default font size in pixels for all tabs fontSize: 14, // font family with optional fallbacks fontFamily: '"SF Mono", FiraCode-Retina, Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace', // default font weight: 'normal' or 'bold' fontWeight: '600', // font weight for bold characters: 'normal' or 'bold' fontWeightBold: 'bold', // line height as a relative unit lineHeight: 1.15, // letter spacing as a relative unit letterSpacing: 1, // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk) cursorColor: 'hsl(0, 0%, 25%)', // terminal text color under BLOCK cursor cursorAccentColor: 'hsl(45, 100%, 50%)', // `'BEAM'` for |, `'UNDERLINE'` for _, `'BLOCK'` for █ cursorShape: 'BLOCK', // set to `true` (without backticks and without quotes) for blinking cursor cursorBlink: false, // color of the text foregroundColor: 'hsl(45, 100%, 50%)', // terminal background color // opacity is only supported on macOS backgroundColor: 'hsl(0, 0%, 0%)', // terminal selection color selectionColor: 'hsl(0, 0%, 25%)', // border color (window, tabs) borderColor: 'hsl(45, 100%, 50%)', // custom CSS to embed in the main window css: '', // custom CSS to embed in the terminal window termCSS: '', // if you're using a Linux setup which show native menus, set to false // default: `true` on Linux, `true` on Windows, ignored on macOS showHamburgerMenu: '', // set to `false` (without backticks and without quotes) if you want to hide the minimize, maximize and close buttons // additionally, set to `'left'` if you want them on the left, like in Ubuntu // default: `true` (without backticks and without quotes) on Windows and Linux, ignored on macOS showWindowControls: '', // custom padding (CSS format, i.e.: `top right bottom left`) padding: '12px 14px', // the full list. if you're going to provide the full color palette, // including the 6 x 6 color cubes and the grayscale map, just provide // an array here instead of a color map object colors: { black: '#000000', red: '#C51E14', green: '#1DC121', yellow: '#C7C329', blue: '#0A2FC4', magenta: '#C839C5', cyan: '#20C5C6', white: '#C7C7C7', lightBlack: '#686868', lightRed: '#FD6F6B', lightGreen: '#67F86F', lightYellow: '#FFFA72', lightBlue: '#6A76FB', lightMagenta: '#FD7CFC', lightCyan: '#68FDFE', lightWhite: '#FFFFFF', }, // the shell to run when spawning a new session (i.e. /usr/local/bin/fish) // if left empty, your system's login shell will be used by default // // Windows // - Make sure to use a full path if the binary name doesn't work // - Remove `--login` in shellArgs // // Bash on Windows // - Example: `C:\\Windows\\System32\\bash.exe` // // PowerShell on Windows // - Example: `C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe` shell: '', // for setting shell arguments (i.e. for using interactive shellArgs: `['-i']`) // by default `['--login']` will be used shellArgs: ['--login'], // for environment variables env: {}, // set to `false` for no bell bell: 'SOUND', // if `true` (without backticks and without quotes), selected text will automatically be copied to the clipboard copyOnSelect: false, // if `true` (without backticks and without quotes), hyper will be set as the default protocol client for SSH defaultSSHApp: true, // if `true` (without backticks and without quotes), on right click selected text will be copied or pasted if no // selection is present (`true` by default on Windows and disables the context menu feature) quickEdit: false, // choose either `'vertical'`, if you want the column mode when Option key is hold during selection (Default) // or `'force'`, if you want to force selection regardless of whether the terminal is in mouse events mode // (inside tmux or vim with mouse mode enabled for example). macOptionSelectionMode: 'vertical', // URL to custom bell // bellSoundURL: 'http://example.com/bell.mp3', // Whether to use the WebGL renderer. Set it to false to use canvas-based // rendering (slower, but supports transparent backgrounds) webGLRenderer: true, // for advanced config flags please refer to https://hyper.is/#cfg }, // a list of plugins to fetch and install from npm // format: [@org/]project[#version] // examples: // `hyperpower` // `@company/project` // `project#1.0.1` plugins: [ 'hyper-quit', ], // in development, you can create a directory under // `~/.hyper_plugins/local/` and include it here // to load it and avoid it being `npm install`ed localPlugins: [], keymaps: { // Example // 'window:devtools': 'cmd+alt+o', }, }; ```
Stanzilla commented 4 years ago

Can you try with a CI build of current canary or maybe compile one yourself? Or setting webGLRenderer: false, in the config.

jsejcksn commented 4 years ago

@Stanzilla Setting webGLRenderer to false has no effect. What is the link to the CI builds?

Stanzilla commented 4 years ago

This is a recent one https://2923-62367558-gh.circle-artifacts.com/0/Users/distiller/project/dist/Hyper-3.1.0-canary.1.dmg

jsejcksn commented 4 years ago

@Stanzilla Thanks. Is there documentation about these builds? I don't see anything newer than 3.0.2 on the releases tab of this repo, and I want to be able to do the following before testing:

Stanzilla commented 4 years ago

We don't have those documented, sorry. All the commits between 3.0.2 and canary are listed here https://github.com/zeit/hyper/compare/3.0.2...canary

The builds are generated by CircleCI https://app.circleci.com/jobs/github/zeit/hyper/2923/artifacts

jsejcksn commented 4 years ago

@Stanzilla Running the app in the linked dmg immediately crashes. No crash report to provide.

Stanzilla commented 4 years ago

yikes!