White line / top border after Mojave upgrade?

[jesseleite]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: MacOS Mojave 10.14
• Hyper.app version: Hyper 2.1.0-canary.2
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/JesseLeite/2d8c5cedcd161a2eafff6647959c29de
• Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
• The issue is reproducible in vanilla Hyper.app:

Issue

After upgrading to Mojave, I notice electron apps have a harsh white border at the top, which is especially noticeable on dark backgrounds. It happens in both dark and light mode. In this case, I have border: 0 !important; styling on my hyper window, so that you can see how apparent it is without the default hyper border...

I've also heard people say that all (even non-electron) windows have it, but native windows look way more natural than electron windows...

I realize this might be actually on electron to fix (see https://github.com/electron/electron/issues/13164), but in that thread apparently the VS Code Insiders build has a 'fix', so I thought I'd share here in case it might be something that could be remedied on Hyper's end?

[lclhst]

This comes with Mojave, but you can disable this ugly line:

defaults write -app [application name] NSRequiresAquaSystemAppearance -bool No

[jesseleite]

Ran defaults write -app Hyper NSRequiresAquaSystemAppearance -bool No and restarted. No go, still see the line?

That said, end users of electron apps shouldn't have to change OS level settings to view electron windows as they were intended to be seen, wouldn't you agree?

[karlhorky]

@lclhst this was mentioned in the electron issue thread, and does not fix the issue completely: https://github.com/electron/electron/issues/13164#issuecomment-424309847

[MariuzM]

I think on one of the Mojave vids one Dev has talked about the gray white border and from my understanding thats a feature, a stupid feature if you ask me, that Dev and who approved need to be fired.