search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.28k stars 3.52k forks source link

Black color is based on background color? #3302

Open nirewen opened 5 years ago

nirewen commented 5 years ago

Issue

Today I discovered this beautiful app called Hyper, and installed it. I was messing around menus and I found that I can edit the colors of the app, and so I did.

The issue is: The background color and black are set to different colors (#1C1C1C and #000000), though, the black color seems to be the same as the background color (see attached screenshot)

I don't think this is an issue with chalk, but maybe an issue with my native terminal (?) Do the colors of the native terminal interfere in Hyper?

My .hyper.js configuration is above, if someone spot my mistake, let me know.

image

robertgrzonka commented 5 years ago

Well, the difference between this two #000000 and #1C1C1C is really small. I may be wrong but I guess that your Windows (as default) supports 256 colors. This two shades of black are included as one color and this is why you see them as one color: black. Google them and check if you see the difference between them when set next to each other. What are you interested in is called true colors which contains ~16 million colors.

Also please check if https://github.com/zeit/hyper/issues/1706#issuecomment-302873966 suits your problem in any way; seems to be related.

nirewen commented 5 years ago

The colors are not that similar at all. Even though, if they were indeed the same color, I could still change the background to another color and #000000 would show, right? Here are the colors side by side image

Also, I tried resetting the terminal as https://github.com/zeit/hyper/issues/1706#issuecomment-302873966 suggested, didn't fix my problem

nirewen commented 5 years ago

Doing some research, I found this: True Colour (16 million colours) Hyper.app is listed in the NOT Supporting section. So in its current version 2.0.0, it doesn't support True Color

robertgrzonka commented 5 years ago

Yes, correct: Hyper is using xterm-256colors protocole which u can check typing in your shell as below:

echo $TERM    #should output: `xterm-256color`

zrzut ekranu 2018-12-2 o 20 55 28 Please check this gray color #404040 if it suites your needs. This may be helpful when looking for another solutions.