vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.33k stars 3.52k forks source link

Visual Bell #3427

Open pelillian opened 5 years ago

pelillian commented 5 years ago

Issue

Feature Request: The regular terminal allows a visual bell instead of an audible one. This is a basic feature that hyper lacks.

federicocandiago commented 3 years ago

I agree with OP. It would be absolutely necessary for some of my use cases.

cherryblossom000 commented 3 years ago

Xterm.js has an onBell event which can be used to implement a visual bell. This is what VSCode does:

            this._xterm?.onBell(() => {
                if (this._configHelper.config.enableBell) {
                    this.statusList.add({
                        id: TerminalStatus.Bell,
                        severity: Severity.Warning,
                        icon: Codicon.bell,
                        tooltip: nls.localize('bellStatus', "Bell")
                    }, this._configHelper.config.bellDuration);
                }
            });

https://github.com/microsoft/vscode/blob/729d81623815a428160b93e930054a1a2a5403ef/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L659-L668

screenshot of visual bell in VSCode

LabhanshAgrawal commented 3 years ago

I see, will check it out