search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.38k stars 3.52k forks source link

update will lose preferences before #3589

Open mazyi opened 5 years ago

mazyi commented 5 years ago

when hyper auto update to 3.0.0, the preferences become default

juancampa commented 5 years ago

@mazyi what OS are you on?

kmpm commented 5 years ago

Same here. Windows 10

ghost commented 5 years ago

same here, I use windows 10 64 bit as well

mgouault commented 5 years ago

Windows 10 64bit too Since I haven't made a save of the configuration file and since my hyper doesn't work at all with WSL without config I'm pretty much 💀 right now

mazyi commented 5 years ago

@juancampa win10 1809

marekkaczkowski commented 5 years ago

Looks like

MikeCoats commented 5 years ago

I had the same happen to me. In the docs on the homepage there's a small note that explains the config search order.

image

It appears that Hyper v3 ships with a config at the $Env:AppData/Hyper/.hyper.js location, so is ignoring the old one.

skoging commented 5 years ago

Otherwise it will be moved to the application directory at first run.

This didn't happen for me atleast, the config in application directory was the default one.

MikeCoats commented 5 years ago

This didn't happen for me atleast, the config in application directory was the default one.

I agree. I deleted the one from my application directory then launched Hyper and it recreated a new default config. It did not copy in my existing config.

Manually copying the old config to the application directory did the trick for me.

haiquang9994 commented 5 years ago

Can I stop auto upgrade? I want use the old version. Version 3.0.0 have issues.

haiquang9994 commented 5 years ago

Can I stop auto upgrade? I want use the old version. Version 3.0.0 have issues.

I run Hyper in windows 10 + WSL I use tmux, when i detach a session. status bar of tmux still appear on screen.

phifa commented 5 years ago

Fixed it. For Windows users copy hyper.js from C:\Users\<username>\ to: C:\Users\<username>\AppData\Roaming\Hyper and restart hyper.

pkit commented 5 years ago

Fixed it. For Windows users copy hyper.js from C:\Users\<username>\ to: C:\Users\<username>\AppData\Roaming\Hyper and restart hyper.

It's not a fix but a workaround. The upgrade script should do it.

cuuupid commented 5 years ago

EDIT 2: For anyone else experiencing the same issue or really any issue, running hyper via the CLI seems to load Hyper perfectly (moreover with all my previous preferences and plugins, all content apart from Windows settings on the executable). This seems to be as my Hyper CLI points to the old one even though checking the version points to 3.0.0?

image

I copied the prefs over but my plugins are all missing, and my shell looks completely different in color. It's also now ignoring my PS1 in WSL and the title is now just the path to bath.exe instead of the directory as it was before.

Is there any way to downgrade to Hyper 2 and revert changes?

Edit: Trying to change some plugins doesn't install it even if I do a full reload or close and open, but it does make the terminal lag out on IO and the window stutter when dragging it around the screen (to clarify, on WSL).

Also, clear on WSL now doesn't clear Hyper's buffer, and although the PS1 is definitely properly closed it doesn't look like the format is clearing.

I'm not entirely sure what's causing this, but based on the colors being shown, it seems like the colors specified in Hyper's preferences are overwriting those in PS1 in some places, and those in PS1 are overwriting Hyper's preferences in other places. It's a little confusing since the PS1 colors should just be using the terminal's definition for that color:

Screen recording 2019-05-06 at 03 30 19 PM

Also, any preferences set in Windows (i.e. an alternative icon for Hyper) are also cleared, this has to be respecified manually I believe as those settings would most likely be gone once the executable is changed.

juancampa commented 5 years ago

and my shell looks completely different in color.

@pshah123 can you try setting this in your config object?

    // Whether to use the WebGL renderer. Set it to false to use canvas-based
    // rendering (slower, but supports transparent backgrounds)
    webGLRenderer: false,
juancampa commented 5 years ago

We're discussing Hyper 3 config migration in https://github.com/zeit/hyper/issues/3605, the plan is to release a migration path as soon as possible

cuuupid commented 5 years ago

and my shell looks completely different in color.

@pshah123 can you try setting this in your config object?

    // Whether to use the WebGL renderer. Set it to false to use canvas-based
    // rendering (slower, but supports transparent backgrounds)
    webGLRenderer: false,

@juancampa the same behaviour occurs unfortunately, it seems this happens most often in WSL -- open issue for it is #3596

mgouault commented 5 years ago

Isn't this fixed by https://github.com/zeit/hyper/pull/3610 ?

cuuupid commented 5 years ago

@mgouault I haven't tested it personally but the color mismatch/conflict still occurs if I migrate my settings manually

hammypants commented 5 years ago

Is there anyway to prefer the user folder to the app folder? It is where basically every dot file configuration lives. (Why was it even swapped?)

Additionally...

Note: config at ~/.hyper.js still supported, but will be ignored, if config in application directory present. Otherwise it will be moved to the application directory at first run.

... reads poorly. ~/.hyperjs is not still supported, it is merely a migration path.