Ctrl+C not killing Node Windows 10, Background Process Created?

[LeonBlade]

• [x] Your Hyper.app version is 3.0.2. Please verify your using the latest Hyper.app version

• [x] I have searched the issues of this repo and believe that this is not a duplicate

  ---

• Any relevant information from devtools? (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A

• Is the issue reproducible in vanilla Hyper.app? Yes.

Issue

Pressing Ctrl+C to quit certain applications spawned by npm do not kill the application (and more).

Verified this by changing the shell config option to be both Powershell and CMD and they both fail. Using bash however does not produce the same result. This seems to have something to do with Windows specifically.

I tested trying to stop the same process on CMD and Powershell not within Hyper and it works fine, so there is something causing this to happen only within the Hyper terminal itself.

I'm not sure this can be reproduced for others, but the exact command I run for my example happens to be something with npm start or npm run dev for example. One project runs a Koa server with Next.js, the other is using cgb-scripts. I also tried on another project with npm build which runs an electron build step and that also cannot be killed with Ctrl+C. Running node itself, the application will close just fine.

Closing the tab will NOT kill the process. If I close the tab, it will keep the process alive in the background. The only way to stop it, is by ending it in the Task Manager or Resource Monitor.

This has only been a recent issue since Hyper 3.

• Hyper version: undefined "3.0.2"

• OS ARCH VERSION: win32 x64 10.0.17763

• Electron: 3.1.3 LANG: undefined

• SHELL: undefined TERM: undefined

  ~/.hyper.js contents

      
        {
  "updateChannel": "stable",
  "fontSize": 12,
  "fontFamily": "Menlo, \"DejaVu Sans Mono\", Consolas, \"Lucida Console\", monospace",
  "fontWeight": "normal",
  "fontWeightBold": "bold",
  "lineHeight": 1,
  "letterSpacing": 0,
  "cursorColor": "rgba(248,28,229,0.8)",
  "cursorAccentColor": "#000",
  "cursorShape": "BLOCK",
  "cursorBlink": false,
  "foregroundColor": "#fff",
  "backgroundColor": "#000",
  "selectionColor": "rgba(248,28,229,0.3)",
  "borderColor": "#333",
  "css": "",
  "termCSS": "",
  "showHamburgerMenu": "",
  "showWindowControls": "",
  "padding": "12px 14px",
  "colors": {
  "black": "#000000",
  "red": "#C51E14",
  "green": "#1DC121",
  "yellow": "#C7C329",
  "blue": "#0A2FC4",
  "magenta": "#C839C5",
  "cyan": "#20C5C6",
  "white": "#C7C7C7",
  "lightBlack": "#686868",
  "lightRed": "#FD6F6B",
  "lightGreen": "#67F86F",
  "lightYellow": "#FFFA72",
  "lightBlue": "#6A76FB",
  "lightMagenta": "#FD7CFC",
  "lightCyan": "#68FDFE",
  "lightWhite": "#FFFFFF"
  },
  "shell": "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
  "shellArgs": [
  ""
  ],
  "env": {},
  "bell": "SOUND",
  "copyOnSelect": false,
  "defaultSSHApp": true,
  "quickEdit": false,
  "macOptionSelectionMode": "vertical",
  "webGLRenderer": true
  }
  
        {
  "plugins": [
  "hyper-dracula"
  ],
  "localPlugins": []
  }
      
    

[OmgImAlexis]

I've also noticed CTRL+C not sending through hyper over SSH. I wonder if this is related.

Running this remotely via terminal on MacOS works without an issue yet with Hyper the script never runs the callback function.

process.on ('SIGINT',() => {
  console.log('You clicked Ctrl+C!');
  process.exit(1);
});

setInterval(() => {
        console.log('running');
}, 1000)

Macbook - Hyper over SSH (Ended up using kill -SIGINT $PID)

running
^C^Crunning
^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^Crunning
^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^Crunning
^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^Crunning
^C^C^C^C^C^Crunning
^C^C^C^Crunning
running
running
running
running
running
running
You clicked Ctrl+C!

Macbook - Terminal over SSH

running
^CYou clicked Ctrl+C!