vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.27k stars 3.52k forks source link

$SHELL still does not change while using with other shells #3795

Open gmontalvoy opened 5 years ago

gmontalvoy commented 5 years ago

Looks like this issue was treated at https://github.com/zeit/hyper/issues/629 but still happening at latest published version

Issue

After a fresh hyper installation, try to change to zsh with chsh -s /bin/zsh and change on .hyper.js (REF GIST) it still unable to change $SHELL to zsh:

echo $SHELL /bin/bash

echo $0 /bin/zsh

If you start default terminal app it is changed to /bin/zsh correctly. Can we revisit this issue as it still happening to some users?

Thank you

LazyRen commented 5 years ago

Same here. Same environment, my native terminal.app gives echo $SHELL /usr/local/bin/zsh echo $0 /user/local/bin/zsh

but Hyper gives me echo $SHELL /bin/zsh echo $0 /user/local/bin/zsh

matthewcoxx commented 4 years ago

I commented on #629 before realizing this thread was here. I am having the same issue as well. Clean Mac 10.15 straight from the Apple store nothing installed before hand. still getting incorrect SHELL paths for hyper.

tani commented 4 years ago

You can change SHELL variable in hyper.js as following.

env: {
  SHELL: "/usr/local/bin/bash"
}

But this is unnatural, this should be fixed.