search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
42.93k stars 3.47k forks source link

Hyperlinks at the end of a sentence erroneously include the period #4444

Open jaraco opened 4 years ago

jaraco commented 4 years ago

I'm using the Azure CLI, and one of the help outputs had this text:

jaraco.functools master $ az devops service-endpoint github create --help

Command
    az devops service-endpoint github create : Create a GitHub service endpoint.
        For automation, set GitHub PAT token in AZURE_DEVOPS_EXT_GITHUB_PAT environment variable.
        You can learn more about this at https://aka.ms/azure-devops-cli-service-endpoint.

If I try to click on that URL, it is highlighted, but it doesn't work because the . is included in the URL. Many other systems like Slack are able to detect hyperlinks like these without including extraneous trailing characters. It would be nice if Hyper could do the same.

LabhanshAgrawal commented 4 years ago

The weblinks functionality comes from xterm itself, I think you should report it there instead. Though I guess it might be difficult as . is a valid character in urls.

jaraco commented 6 months ago

I've observed that it's not just the period, but any punctuation, including >, ), and probably others.

image

jaraco commented 6 months ago

The upstream bug has been fixed (ref). What will it take to get this fix integrated into Hyper?