search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.38k stars 3.52k forks source link

improve clickable uri's to recognize file:// #5133

Open xenoterracide opened 3 years ago

xenoterracide commented 3 years ago

so... spotbugs for gradle is lovely... it gives me a file:// link to the report. I'd like this to open in my browser, which I believe is the default configured behavior... at least that's what terminus with the link plugin does. I believe I've seen something else do it too, but I can't remember what/when. Honestly this is reason 1 that I'm seeking a new terminal, reason 2 is that I'm going to be using windows again, and might be nice to use the same terminal everywhere.

LabhanshAgrawal commented 3 years ago

We use xterm-addon-web-links to do the link matching, you can open an issue there xterm

xenoterracide commented 3 years ago

can I ask a question? why do open source developers (I am one, but I appear to be the exception unless I've abandoned something) don't file the bugs with the upstream projects themselves? I do not know the api calls you have done so I will not be as effective at opening the bug, however, I am doing it now.

LabhanshAgrawal commented 3 years ago

For me I open them sometimes myself sometimes not, it's a bit random, haven't really noticed if this is a common behaviour.

xenoterracide commented 3 years ago

please see the closed ticket opened, they say there's a solution already.

LabhanshAgrawal commented 3 years ago

I see, I'll try to add it when I get some free time, pr's also welcome.

LabhanshAgrawal commented 3 years ago

@xenoterracide can you try a build from https://github.com/LabhanshAgrawal/hyper/actions/runs/588560377 and check

Right now it's a very simple regex so might miss few things

LabhanshAgrawal commented 3 years ago

@xenoterracide ping

xenoterracide commented 3 years ago

Sorry, I have been out of town, because of snovid in Austin, TX. Between work and job hunting I'm slammed, but I'll see what I can do. Really thinking about making another gradle spotbugs plugin too.

On Sat, Feb 27, 2021, 12:36 PM Labhansh Agrawal notifications@github.com wrote:

@xenoterracide https://github.com/xenoterracide ping

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vercel/hyper/issues/5133#issuecomment-787107702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABLDKKMTXGRJ5GSNRI5WLTBEUTRANCNFSM4UTNKC5A .

xenoterracide commented 3 years ago

wow, sorry, in the hell I was in at work, I forgot about this. Should I still try that? does it need updating, I just grabbed 3.1.2

LabhanshAgrawal commented 3 years ago

Please do try it out. You can grab it from https://github.com/vercel/hyper/actions/runs/1134546032