Hyper implicitly using Notepad to edit preferences - Githubissues

vercel / hyper

A terminal built on web technologies

https://hyper.is

MIT License

43.27k stars 3.52k forks source link

Hyper implicitly using Notepad to edit preferences #5504

Open aaryanporwal opened 3 years ago

aaryanporwal commented 3 years ago

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: OS Name: Microsoft Windows 10 Home Single Language OS Version: 10.0.19041 N/A Build 1904
Hyper.app version: 3.0.2 (latest)
The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

Hyper implicitly uses Notepad.exe to edit its preferences, but from Windows 2004 onwards, notepad has become an optional feature and doesn't come pre-installed. This leads to the following error:

RealCyGuy commented 3 years ago

It's not implicit, it's used as a fallback. https://github.com/vercel/hyper/blob/80c7e67a0d3c83baa2124ef5b1fa8a88f8b56808/app/config/open.ts#L55 It uses notepad when there isn't a default app for .js files.

RealCyGuy commented 3 years ago

I think wordpad is still preinstalled, it can be a fallback for notepad.

aaryanporwal commented 3 years ago

Yeah wordpad is a better fallback, thanks!

Stanzilla commented 3 years ago

If you don't have Notepad, that's a bug. Notepad is still installed by default on Windows 10.

https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/features-on-demand-non-language-fod

aaryanporwal commented 3 years ago

It is under optional features: https://answers.microsoft.com/en-us/windows/forum/windows_10-files/notepad-missing-in-windows-10-v2004/aefadf15-e830-4279-b9a3-591581ebb35a

Stanzilla commented 3 years ago

Yes but no Notepad being installed is a bug and not intended.

karstengresch commented 1 year ago

No notepad installed can be a decision ;)

Thus, the error message should be changed to:

" Cannot find the default editor for .js files to open '.hyper.js'. Please make sure you have a default text editor set up to open .js files. "