HyperJS renders l and h on every newline on Windows WSL

vercel / hyper

A terminal built on web technologies

https://hyper.is

MIT License

43.2k stars 3.5k forks source link

HyperJS renders l and h on every newline on Windows WSL #6532

Open pakoito opened 2 years ago

pakoito commented 2 years ago

[X] I am on the latest Hyper.app version
[X] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10 Latest
Hyper.app version: 3.2.3
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/pakoito/1c784fc649615ca1bcf0784b601e9750
The issue is reproducible in vanilla Hyper.app: Yes

Issue

HyperJS renders endline l and newline h markers on Windows and WSL. These disappear if you force a re-render by resizing the window. Neither WebGL nor Canvas rendering fix this issue.

hyper_problem_2

nardoor commented 2 years ago

Hello @pacoworks,

Could you provide some more information ?

Could you confirm that if you open your WSL on another terminal emulator you don't observe this issue ?
Could you share details on your prompt theme ? With another prompt (maybe more basic) do you still observe the issue ?

Thanks.

pakoito commented 2 years ago

Hello! Thank you for replying quickly!!

Could you confirm that if you open your WSL on another terminal emulator you don't observe this issue ?

Microsoft's Terminal, the modern one: hyper_problem_3

Could you share details on your prompt theme ? With another prompt (maybe more basic) do you still observe the issue ?

Sure! I use starship.rs for the prompt, both for Powershell and fish (WSL). No configuration change seems to fix it.

hyper_problem_4

nardoor commented 2 years ago

@pakoito I couldn't reproduce so far, could you provide details about these two topics ?

If you don't use startship.rs (but bash or zsh instead) is the issue still there ?
What configuration / presets are you using with starship.rs ?

pakoito commented 2 years ago

If you don't use startship.rs (but bash or zsh instead) is the issue still there ?

It does not, it seems. It may be the combo or startship + oh my fish (forgot to mention)?

20:53:12] ƛ omf theme
 Installed:
beloglazov      default         scorphish

20:54:13] ƛ omf list
 Plugins
bass            fish-nvm        fish-spec       omf

The OMF theme doesn't seem to influence it.

What configuration / presets are you using with starship.rs ?

Nothing too fancy: https://gist.github.com/pakoito/978560d1f83ea6acdd35200f57519bcd

nardoor commented 2 years ago

What's your WSL version ?

Mine is 5.10.16.3-microsoft-standard-WSL2 and I am not able to reproduce the issue

pakoito commented 2 years ago

I couldn't find the version of the executable, but I do know I'm running WSL1.

If you cannot repro just close it, you already did more than enough. Thank you :D