search

vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.24k stars 3.51k forks source link

Allow overriding the default shell on Windows #8041

Closed jaraco closed 1 day ago

jaraco commented 1 day ago

Is your feature request related to a problem? Please describe. On Unix, I can chsh the default shell to my preferred shell and Hyper will honor that.

On Windows, there's no way to configure a default shell, as far as I can tell. I've tried overriding the COMSPEC variable, but that has no effect on Hyper.

I'd like not to have to configure the default shell in the configuration file as I'd like to re-use the same configuration file that I use on other platforms.

Describe the solution you'd like Ideally, the user could configure something in the environment to change the default shell (e.g. DEFAULT_SHELL=%userprofile%/.local/bin/myshell.exe), and Hyper would honor that.

jaraco commented 1 day ago

On further examination, I determined that the default-shell package as used by Hyper does honor COMSPEC. I must have done something wrong the first time I tried. I was able to configure COMSPEC in my environment and now Hyper loads that shell even when shell: '',.