vercel / modelfusion

The TypeScript library for building AI applications.
https://modelfusion.dev
MIT License
1.06k stars 76 forks source link

Make maxValuesPerCall configurable for OpenAI text embedding models #195

Closed nanotronic closed 7 months ago

nanotronic commented 7 months ago

I hope that's the right approach.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modelfusion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 6:58pm
lgrammel commented 7 months ago

@nanotronic yeah that should be it - thank you! did you test it out?

nanotronic commented 7 months ago

Yes, first I successfully tried the value change in the example node folder. Then I made the changes. And after reading the pull request and contributions, I built locally and copied the changed files to the appropriate place in the example-node-folder. That also worked. Only npm link modelfusion did not work somehow.

lgrammel commented 7 months ago

Yes, first I successfully tried the value change in the example node folder. Then I made the changes. And after reading the pull request and contributions, I built locally and copied the changed files to the appropriate place in the example-node-folder. That also worked. Only npm link modelfusion did not work somehow.

What issue did you run into with npm link modelfusion? (it's important to link from the main dist directory first using npm link)