vercel / ncc

Compile a Node.js project into a single file. Supports TypeScript, binary addons, dynamic requires.
https://npmjs.com/@vercel/ncc
MIT License
9.27k stars 291 forks source link

Cannot use 'import.meta' outside a module on 0.36.0 (not 0.34.0) #1019

Open frbuceta opened 1 year ago

frbuceta commented 1 year ago

I just updated from version 0.34.0 to 0.36.0. In version 0.34.0 it works perfectly.

ncc: Version 0.36.0
ncc: Compiling file index.js into CJS
...
esm_dirname = (0,external_url_.fileURLToPath)(import.meta.url);
                                                       ^^^^

SyntaxError: Cannot use 'import.meta' outside a module
...
imyelo commented 1 year ago

source:

import { fileURLToPath } from "url"

fileURLToPath(`${import.meta.url}/../somestaticfile.txt`)

compile with 0.34.0:

import { createRequire as __WEBPACK_EXTERNAL_createRequire } from "module";
/******/ /* webpack/runtime/compat */
/******/ 
/******/ if (typeof __nccwpck_require__ !== 'undefined') __nccwpck_require__.ab = new URL('.', import.meta.url).pathname.slice(import.meta.url.match(/^file:\/\/\/\w:/) ? 1 : 0, -1) + "/";
/******/ 
/************************************************************************/
var __webpack_exports__ = {};

;// CONCATENATED MODULE: external "url"
const external_url_namespaceObject = __WEBPACK_EXTERNAL_createRequire(import.meta.url)("url");
;// CONCATENATED MODULE: ./src/index.js

(0,external_url_namespaceObject.fileURLToPath)(`${"file:///project/home/imyelo/workspace/src/index.js"}/../somestaticfile.txt`);

compile with 0.36.0:

import { createRequire as __WEBPACK_EXTERNAL_createRequire } from "module";
/******/ /* webpack/runtime/compat */
/******/ 
/******/ if (typeof __nccwpck_require__ !== 'undefined') __nccwpck_require__.ab = new URL('.', import.meta.url).pathname.slice(import.meta.url.match(/^file:\/\/\/\w:/) ? 1 : 0, -1) + "/";
/******/ 
/************************************************************************/
var __webpack_exports__ = {};

;// CONCATENATED MODULE: external "url"
const external_url_namespaceObject = __WEBPACK_EXTERNAL_createRequire(import.meta.url)("url");
;// CONCATENATED MODULE: ./src/index.js

(0,external_url_namespaceObject.fileURLToPath)(`${import.meta.url}/../somestaticfile.txt`);

seems like webpack doesn't convert import.meta.url staticly in ncc ^0.36.0

reproduces in https://codesandbox.io/p/sandbox/funny-rain-y4qvps

schowdhuri commented 8 months ago

Thanks for this! I had to downgrade all the way from 0.38 to make this work 🤷🏽‍♂️

phisch commented 8 months ago

I just ran into the same issue, and downgrading to 0.34.0 worked for me as well. What a coincidence that we run into the same issue just 8 hours apart, when it's been inactive for a year!

meienberger commented 6 hours ago

Has there been a workaround found for this issue? I managed to pinpoint the problematic import.meta.url inside one of my dependencies. Removing it solves the issue but also downgrading to 0.34.0 solves it. Is it possibly this change which is causing this issue?