fix: upgrade to `terser@5.31.0` to fix minfy with negated `in` statements

vercel / ncc

Compile a Node.js project into a single file. Supports TypeScript, binary addons, dynamic requires.

https://npmjs.com/@vercel/ncc

MIT License

8.99k stars 285 forks source link

fix: upgrade to `terser@5.31.0` to fix minfy with negated `in` statements #1194

Open byCedric opened 4 weeks ago

byCedric commented 4 weeks ago

Fixes #1193

byCedric commented 3 weeks ago

These are interesting failures, I'm not sure why Node 20 on Ubuntu causes that error, while Node 20 on Windows seems fine.

The MacOS errors are just node-gyp (install) related issues, likely due to the GHA runner missing some low-level dependency. It's also erroring on node-canvas which isn't touched in this PR.

Edit: yeah, the macos failures are definitely related to missing system dependencies:

byCedric commented 3 weeks ago

Also interesting here is that the last run on workflow (4 months ago) did not succeed for Node 20 on Ubuntu (this run). Unfortunately, the logs have been wiped already, but that might be a pointer to this failure too.

I'm also guessing the macos-latest runner has been changed within 4 months, causing the CI failures.

styfle commented 3 weeks ago

I see what you mean. I'll run CI against main to see how it compares:

https://github.com/vercel/ncc/pull/1195

byCedric commented 3 weeks ago

Glad you could repro this on main (as in, not caused by this PR) 😄

Anything I can do to help?

styfle commented 3 weeks ago

I think we need to fix main before merging this to confirm it works as expected