Change `ms` to `moment`

vercel / next-react-server-components

Demo repository for Next.js + React Server Components

https://next-rsc-hn.vercel.app

MIT License

984 stars 158 forks source link

Change `ms` to `moment` #42

Closed shuding closed 1 year ago

shuding commented 2 years ago

This is to demonstrate that modules used in Server Components will never be shipped to the client side, but traditional SSR and CSR pages do. So moment adds an additional 25kb to /ssr and /csr, but not for /rsc.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/next-rsc-news/2LeNpTLKr2XsZp2Wp5htnJ3QWaus
✅ Preview: https://next-rsc-news-git-shu-ecee.vercel.sh

vercel-team commented 2 years ago

📝 Changed routes:

/csr	/
^{(view full size)}	^{(view full size)}

/item.server	/rsc.server
^{(view full size)}	^{(view full size)}

/slow.server	/ssr
^{(view full size)}	^{(view full size)}

Commit 6bb9f10bbd5b922e6e83c84abdaf754be0e38df0 (https://next-rsc-news-pwxtp2m42.vercel.sh).

leerob commented 1 year ago

Gonna close this as stale (since there's now merge conflicts after the refactor). Let me know if this is still something we want to do!