vercel / next-react-server-components

Demo repository for Next.js + React Server Components
https://next-rsc-hn.vercel.app
MIT License
976 stars 156 forks source link

Refactor to Next.js 13 and `app` directory #53

Closed gfortaine closed 1 year ago

vercel[bot] commented 1 year ago

@gfortaine is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-rsc-news ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 2:09AM (UTC)
leerob commented 1 year ago

Hey! I don't have push access here. I made a PR: https://github.com/gfortaine/next-react-server-components/pull/1

gfortaine commented 1 year ago

@leerob PR merged 🎉

leerob commented 1 year ago

Hey! Sorry one thing I should have been more clear about - I think we can ditch all of the CSR/slow examples and just do the RSC/streaming one as the main index page. I started down this route in my PR 👍

gfortaine commented 1 year ago

@leerob Copy that 👍 MR updated accordingly :

vercel-team commented 1 year ago

📝 Changed routes:

6 deleted routes:

Commit cc3d9b3d4389840a346a86f95639633e6647eebc (https://next-rsc-news-13vw4p4as.vercel.sh).

gfortaine commented 1 year ago

@leerob Just discovered a very annoying bug by finishing this MR (to get the id searchParam in ItemPage Server Component) : https://github.com/vercel/next.js/issues/42856

leerob commented 1 year ago

Thank you so much for your help here! Sending you an email for some swag 😄 This PR is already getting fairly large, so let's go ahead and merge forward and address bugs as we see them.

For example, I think there should be no surrounding padding on mobile. But it's minor, and good that this repo gets updated so folks don't try exploring the old version that won't work 😄

mb21 commented 1 year ago

Hello! any particular reason you're using a plain old html <a> tag instead of the Next <Link component? This is essentially a MPA. From reading the beta docs for app directory, I understood the recommended approach to still be SPA? Thanks for clarification!