vercel / next.js

The React Framework
https://nextjs.org
MIT License
126.99k stars 26.99k forks source link

Missing `next dev --turbo` features #49174

Closed padmaia closed 6 months ago

padmaia commented 1 year ago

The Turbopack dev server is nearly feature complete, but here is a list of some outstanding issues:

Released in 13.5

sanny-io commented 1 year ago

It also does not support exporting.

https://nextjs.org/docs/app/building-your-application/deploying/static-exports#configuration

padmaia commented 1 year ago

It also does not support exporting.

This issue is specifically for dev server features. Production builds are not supported at all yet. At one point next dev --turbo would fail if you had this option configured, but now it will ignore it since it isn't relevant.

crusoexia commented 1 year ago

How about "Module federation" for micro-frontend architecture?

adamrneary commented 1 year ago

We are really excited to get this a try over at Watershed. For now, turbopack is failing because we are employing the experimental.externalDir flag, which we seem to believe that we need for our monorepo use case with pnpm. (See https://github.com/vercel/next.js/discussions/26420).

But this seems like a possible miscommunication, because Turbopack, Turborepo, Next.js…are all the same team. :)

Is there a working example of a monorepo that uses Turborepo and Turbopack with Next 13, where an app in one project is relying on, for example, UI components in another project? This seems like a bread and butter example, but we must have it wrong somewhere!

lutfi-haslab commented 1 year ago

I have error hydration using turbo,

Error: Text content does not match server-rendered HTML.

See more info here: https://nextjs.org/docs/messages/react-hydration-error

and warning

Error: There was an error while hydrating this Suspense boundary. Switched to client rendering.

it works normally without --turbo i am using it because much faster than dev only

TzviPM commented 1 year ago

Not sure if this should be included in this list: https://github.com/vercel/turbo/issues/5347

OttlikG commented 1 year ago

I'm getting error when importing sass file from external lib from node_modules

@import '~flexboxgrid/css/flexboxgrid.css';

unable to resolve module "~flexboxgrid" with subpath "/css/flexboxgrid.css"
lachlanjc commented 1 year ago

Good news, webp image support landed in today's release! #52285

TzviPM commented 1 year ago

I went to test the new webp support, and I'm now experiencing an issues with route groups:

Non matching path () provided for /(main)

I have a main site and a microsite that don't share much layout, so my site (minus icons and metadata) is separated into a (main) route group and a (microsite) group, each with their own top-level layout.

When I try to load the home page in (main) with next dev --turbo, I get the following error information:

Non matching path () provided for /(main)

Debug info:
- Execution of get_from_source failed
- Execution of resolve_source_request failed
- Execution of NodeRenderContentSource::get failed
- Non matching path () provided for /(main)

I don't have time to create a minimal repro right now, but if anyone has a similar issue, please feel free to tag me on any speculative work and I can try to pitch in when I have time.

ghost commented 1 year ago

I'm definitely running into the same problem as @TzviPM. Normal next dev works fine though. For the time being I'll just stick to normal webpack while NextJS team sorts this out.

osdiab commented 1 year ago

It also fails if you have typedRoutes FYI

Hollayemi commented 1 year ago

I'm running into the same problem as @TzviPM. it works fine without the parenthesis though.

tosave04 commented 1 year ago

Edit: Route Groups works from 13.4.13-canary.5

I get the same problem on Route Groups with turbo as @TzviPM, after testing on a minimal app, the problem occurs only in --turbo and from next version 13.4.10-canary.5 Error message

Non matching path () provided for /(site)/(pages)

Debug info:
- Execution of get_from_source failed
- Execution of resolve_source_request failed
- Execution of NodeRenderContentSource::get failed
- Non matching path () provided for /(site)/(pages)
Hollayemi commented 1 year ago

I am using webpack for now, I don't know what to do

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Thomas @.> Sent: Tuesday, July 25, 2023 12:59:08 PM To: vercel/next.js @.> Cc: Oluwasusi Stephen Olayemi @.>; Comment @.> Subject: Re: [vercel/next.js] Missing next dev --turbo features (Issue #49174)

I get the same problem on Route Groups with turbo as @TzviPMhttps://github.com/TzviPM, after testing on a minimal app, the problem occurs only in --turbo and from next version 13.4.10-canary.5 Error message

Non matching path () provided for /(site)/(pages)

Debug info:

— Reply to this email directly, view it on GitHubhttps://github.com/vercel/next.js/issues/49174#issuecomment-1649697017, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM7MNMPM5DQQCMXOQVULJ7TXR6YIZANCNFSM6AAAAAAXU7A4BE. You are receiving this because you commented.Message ID: @.***>

brianbit9 commented 1 year ago

Same issue

Non matching path (login) provided for /(pages)/login

winverse commented 1 year ago

same issue

next @13.4.6 Runing

next @13.4.7 Runing

next @13.4.8 Runing

next @13.4.9 Runing

next @ 13.4.10

Debug info:
- Execution of get_from_source failed
- Execution of resolve_source_request failed
- Execution of NodeRenderContentSource::get failed
- Non matching path () provided for /(list)

next @ 13.4.11

Debug info:
- Execution of <NodeRenderContentSource as GetContentSourceContent>::get failed
- Non matching path () provided for /(list)

next @13.4.12

Debug info:
- Execution of <NodeRenderContentSource as GetContentSourceContent>::get failed
- Non matching path () provided for /(list)

See: https://github.com/velog-io/velog/tree/main/packages/velog-web

cpeaustriajc commented 1 year ago

7c67b1216cecdd75f054a859766615880e1d50ed Fixes the route groups issue, it landed at 13.4.13-canary.5

mattcoker commented 1 year ago

7c67b12 Fixes the route groups issue, it landed at 13.4.13-canary.5

Can confirm, 13.4.13-canary.5 fixed the route groups bug for me.

cutsoy commented 1 year ago

I'm running into some issues getting Intercepting Routes to work. Has anyone else managed to get it working with Turbo (or with SSG)?

2Senn commented 10 months ago

having the same issue as @lutfi-haslab hydration error when importing a client component into a server component. It works fine on normal dev. Anyone found a workaround for this?

wojtekmaj commented 7 months ago

It looks like we're nearing Turbo release with 99.7% tests passing, and yet, Turbo is STILL unable to resolve any modules with extensions. I'm getting hundreds and hundreds of errors like:


./packages/site-structure/index.ts:1:0
Module not found: Can't resolve './src/siteStructure.js'
> 1 | import { getSiteStructure } from './src/siteStructure.js';
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2 |
  3 | import type {
  4 |   IPageEntryCollectionPartial,

https://nextjs.org/docs/messages/module-not-found

This is easily resolved with a hack on Webpack's side:

  webpack: (config) => {
    config.resolve.extensionAlias = {
      '.js': ['.js', '.ts', '.tsx'],
    };
    return config;
  },

which is also ridiculous, but at least it works.

timneutkens commented 6 months ago

Going to close this specific issue as we no longer need a larger tracking issue, please report bugs / changes you'd like in a new issue.

In case of @wojtekmaj we already chatted on X but .js resolving as .ts is planned, that is not supported with Next.js out of the box today with webpack either so there's no tests for it. In this case you edited webpack configuration to change the resolving.

pawelblaszczyk5 commented 6 months ago

Going to close this specific issue as we no longer need a larger tracking issue, please report bugs / changes you'd like in a new issue.

In case of @wojtekmaj we already chatted on X but .js resolving as .ts is planned, that is not supported with Next.js out of the box today with webpack either so there's no tests for it. In this case you edited webpack configuration to change the resolving.

Any plans for experimental.typedRoutes in turbo?

timneutkens commented 6 months ago

Eventually yes, but right now we're focusing on stable features and bugfixes first as there's only so much time in day 🙂

pawelblaszczyk5 commented 6 months ago

Understandable 😃 Just wanted to know whether it’s planned at all, thank you very much for the answer, awesome job!

github-actions[bot] commented 6 months ago

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.