vercel / next.js

The React Framework
https://nextjs.org
MIT License
125.91k stars 26.87k forks source link

Example uses hard coded domain instead of localhost and misses reference to .env file in "how to use" #56620

Open PacoSoftwerft opened 1 year ago

PacoSoftwerft commented 1 year ago

Verify canary release

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #36-Ubuntu SMP PREEMPT Fri Jul 14 13:27:38 UTC 2023
Binaries:
  Node: 18.18.0
  npm: 10.1.0
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 13.5.4
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 4.9.5
Next.js Config:
  output: N/A

Which example does this report relate to?

with-zones-app

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

The example is not using the local blog application (localhost:4000) but "https://with-zones-blog.vercel.app".

The home/.env file and the variable BLOG_URL are mentioned in the "Deploy on Vercel" section but should be mentioned in the "How to use" section,too or even better BLOG_URL should be http://localhost:4000 out of the box.

When you use the example in stackblitz no changes in blog will show until you change the .env

Expected Behavior

When I follow the "How to use" section or open the example on stackblitz, code changes in blog should apply. The blog part should be rendered from the example (localhost:4000) and not from with-zones-blog.vercel.app

Problem since 13.4.13 redirects on localhost with pages router are looping see -> https://github.com/vercel/next.js/issues/56615

To Reproduce

Open stackblitz example and change something in blog/pages/post/[id].tsx and check for your changes.

Caryyon commented 3 days ago

@ijjk this issue can be closed, it was resolved in this PR