vercel / next.js

The React Framework
https://nextjs.org
MIT License
127.02k stars 26.99k forks source link

Route caching not working when forced #57542

Closed AaronLayton closed 1 year ago

AaronLayton commented 1 year ago

Link to the code that reproduces this issue

https://cache-test-inky.vercel.app/api/user/1/bookmarks

To Reproduce

  1. Load the URL and note the date in the currentTimestamp
  2. Refresh fast and the datestamp stays the same
  3. Give it a few seconds and then refresh and the timestamp is updated again

Current vs. Expected behavior

I would expect this to be a static response all the time.

Code_2FgFns9KmM

Verify canary release

Provide environment information

Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 10 Pro
Binaries:
  Node: 18.17.1
  npm: N/A
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 13.5.6
  eslint-config-next: 14.0.0
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.2.2
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

App Router

Additional context

I am exploring the caching of API routes to ensure DB requests are not called on highly used route endpoings.

I have DB calls with unstable_cache and a tag against then and then a User endpoint where I use the userId in the URL. My aim here is to static cache the users endpoint where internally I make 4 separate cached calls to the db for separate pieces of information.

I am exploring that the users endpoint is cached all the time, until I run revalidateTag to clear 1 of the data calls and then run revalidatePath to clear the statically generated user response.

In my testing all 4 tagged calls get cleared when I revalidate the path, so was doing some testing here and it seems none of it seems to work in this way.

github-actions[bot] commented 1 year ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources