Closed devjiwonchoi closed 2 days ago
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer
New and removed dependencies detected. Learn more about Socket for GitHub โ๏ธ
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/husky@9.0.11 | environment, filesystem, shell | 0 |
3.61 kB | typicode |
npm/lint-staged@15.2.2 | Transitive: environment, filesystem, shell | +48 |
2.16 MB | okonet |
๐ฎ Removed packages: npm/husky@8.0.0, npm/lint-staged@10.1.7
@devjiwonchoi Is escaping the filenames also no longer necessary?
Commit: 0e0d1b223b507fbdd46dbe94ff5a30ef5e15153a
Commit: 0e0d1b223b507fbdd46dbe94ff5a30ef5e15153a
__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts
(PPR)
Read more about building and testing Next.js in contributing.md.
Yes, the escaping seems unnecessary by now since it was added from Timer facing an issue with mapping [bracketed]
entries, and it should not affect on current change as we are not mapping at all.
Confirmed that it is fine with the mentioned bracket issue above.
https://github.com/vercel/next.js/assets/120007119/920a410f-b690-42ed-9338-95507871fa59
@ijjk I removed escaping since it has no issue in the current config:
https://github.com/vercel/next.js/assets/120007119/b64b6047-dd82-499c-9b5d-efc234b51049
The escaping was added in circumstances where the files were passed via function and mapped as string, so needed escape within the string.
Current lint-staged only runs on each staged file and haven't found related issue over lint-stage v10, so removed it.
x-ref: https://github.com/vercel/next.js/pull/65861#issuecomment-2121494551
For --with-node-modules
, I misunderstood the effect, my bad. Need to revert this one yes.
Why?
The current
lint-staged
hook uses function signature to target the staged files and has extra steps for handling those files that seem to have been passed on from a 5-year-old legacy code.The entire process is unnecessary today since
lint-staged
only runs on the staged files.How?
This PR removed unnecessary logic, removed some no-effect flags, and removed
git add
.