vercel / next.js

The React Framework
https://nextjs.org
MIT License
122.59k stars 26.23k forks source link

Make synced react-is version more obvious #67189

Closed eps1lon closed 3 days ago

eps1lon commented 3 days ago

We treated react-is separately in a separate task but it really should be handled the same as React, ReactDOM etc.

It is still missing a vendored version of the experimental release channel. We only use isValidElementType though and that method needs to move to the renderer anyway. I'd rather prioritize the renderer work instead of more aliasing effort in our bundler.

Test plan

-pushd packages/next && rm -rf src/compiled/react-is && pnpm taskr copy_vendor_react will leave everything as-is

eps1lon commented 3 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eps1lon and the rest of your teammates on Graphite Graphite

ijjk commented 3 days ago

Tests Passed