Closed torresgol10 closed 1 week ago
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer
I don't know if comments referring to graceful-fs
should be deleted.
finally it uses the native one through graceful-fs
How do you know?
@eps1lon Inside the rename file in packages/next
, is the implementation of retrying the rename of a file.
As far as I have seen in graceful-fs
that would only work for Win32, but Next already controls that to do its own retry.
Even typescript provides documentation for node:fs/promise
so I thought I was using native.
If we look at the implementation of graceful-fs
it is similar to the implementation of next controlling the same errors by making fs.rename.
https://github.com/isaacs/node-graceful-fs/blob/main/polyfills.js
Commit: 84753ae96b268fe5b1b0a68b15b5d4202ead1c02
Remove the dependency
graceful-fs
and types.I have looked at the project and it is only used in one file, inside this file only
fs
is imported but not the functionality provided by the library, finally it uses the native one throughgraceful-fs
, I have simplified the logic and removed the unnecessary library. The retry functionality is implemented in the file and is not used from the dependency