vercel / next.js

The React Framework
https://nextjs.org
MIT License
124.58k stars 26.59k forks source link

Rewrite does not set the correct x-forwarded-host in Vercel #67469

Open hector opened 2 months ago

hector commented 2 months ago

Link to the code that reproduces this issue

https://github.com/hector/middleware-web

To Reproduce

The basic code to trigger this bug is simply to use a rewrite in the middleware of Next.js like this:

return NextResponse.rewrite(url, { request: req });

If you click on this link https://middleware-web.vercel.app/?rewrite=https://request-headers-web.vercel.app/ you are reproducing this issue.

This is what is happening:

Code of https://middleware-web.vercel.app/ is public in this repo https://github.com/hector/middleware-web Code of https://request-headers-web.vercel.app/ is public in this repo https://github.com/hector/request-headers-web

Current vs. Expected behavior

I would expect to receive the following headers in https://request-headers-web.vercel.app/ server:

This is what I is actually received (it is printed in the page and can be easily seen):

The header x-forwarded-host is not set to the original host before the rewrite. MDN Reference here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host.

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 22.6.0: Mon Apr 22 20:51:27 PDT 2024; root:xnu-8796.141.3.705.2~1/RELEASE_ARM64_T6020
  Available memory (MB): 16384
  Available CPU cores: 10
Binaries:
  Node: 20.13.1
  npm: 10.5.2
  Yarn: 1.22.22
  pnpm: 9.3.0
Relevant Packages:
  next: 15.0.0-canary.54 // Latest available version is detected (15.0.0-canary.54).
  eslint-config-next: N/A
  react: 19.0.0-rc-6f23540c7d-20240528
  react-dom: 19.0.0-rc-6f23540c7d-20240528
  typescript: 5.3.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Middleware

Which stage(s) are affected? (Select all that apply)

Vercel (Deployed)

Additional context

No response

hector commented 1 month ago

Hey it would be nice if somebody could take a look into that