vercel / next.js

The React Framework
https://nextjs.org
MIT License
124.86k stars 26.66k forks source link

Response.redirect with relative URLs not working for Route Handlers #67966

Open leerob opened 1 month ago

leerob commented 1 month ago

Link to the code that reproduces this issue

https://github.com/vercel/redirect-reproduction

To Reproduce

Actual

  1. Navigate to localhost:3000/test
  2. See error below
 ⨯ TypeError: Failed to parse URL from /test
    at Response.redirect (node:internal/deps/undici/undici:4393:17)
    at GET (/Users/leerob/Developer/scratch/repro/.next/server/chunks/[root of the server]__1d2930._.js:31:21)
    ... 38 lines matching cause stack trace ...
    at async Server.requestListener (/Users/leerob/Developer/scratch/repro/node_modules/.pnpm/next@15.0.0-canary.73_react-dom@19.0.0-rc-512b09b2-20240718_react@19.0.0-rc-512b09b2-20240718_kqhq7uzfl3zawjcrarvtpd6ica/node_modules/next/dist/server/lib/start-server.js:142:13) {
  [cause]: TypeError: Invalid URL
      at new URL (node:internal/url:797:36)
      at Response.redirect (node:internal/deps/undici/undici:4391:23)
      at GET (/Users/leerob/Developer/scratch/repro/.next/server/chunks/[root of the server]__1d2930._.js:31:21)
      at /Users/leerob/Developer/scratch/repro/node_modules/.pnpm/next@15.0.0-canary.73_react-dom@19.0.0-rc-512b09b2-20240718_react@19.0.0-rc-512b09b2-20240718_kqhq7uzfl3zawjcrarvtpd6ica/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:66499
      at /Users/leerob/Developer/scratch/repro/node_modules/.pnpm/next@15.0.0-canary.73_react-dom@19.0.0-rc-512b09b2-20240718_react@19.0.0-rc-512b09b2-20240718_kqhq7uzfl3zawjcrarvtpd6ica/node_modules/next/dist/server/lib/trace/tracer.js:173:36
      at NoopContextManager.with (/Users/leerob/Developer/scratch/repro/node_modules/.pnpm/next@15.0.0-canary.73_react-dom@19.0.0-rc-512b09b2-20240718_react@19.0.0-rc-512b09b2-20240718_kqhq7uzfl3zawjcrarvtpd6ica/node_modules/next/dist/compiled/@opentelemetry/api/index.js:1:7062)

Current vs. Expected behavior

Expected

  1. Navigate to localhost:3000/test
  2. Redirects to localhost:3000

Note that this does work as expected:

import { redirect } from 'next/navigation';

export async function GET(request: Request) {
  redirect('/test');
}

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:42 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6000
  Available memory (MB): 32768
  Available CPU cores: 10
Binaries:
  Node: 20.15.1
  npm: 10.7.0
  Yarn: 1.22.21
  pnpm: 9.4.0
Relevant Packages:
  next: 15.0.0-canary.73 // Latest available version is detected (15.0.0-canary.73).
  eslint-config-next: N/A
  react: 19.0.0-rc-512b09b2-20240718
  react-dom: 19.0.0-rc-512b09b2-20240718
  typescript: 5.5.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Navigation

Which stage(s) are affected? (Select all that apply)

next dev (local)

Additional context

No response

github-actions[bot] commented 1 month ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources