search

vercel / next.js

The React Framework
https://nextjs.org
MIT License
125.95k stars 26.87k forks source link

devIndicators `buildActivityPosition` option doesn't work #68701

Open Marukome0743 opened 2 months ago

Marukome0743 commented 2 months ago

Link to the code that reproduces this issue

https://github.com/Marukome0743/not-work-devIndicator-options

To Reproduce

  1. Run create-next-app@canary
  2. Add devIndicators options such as buildActivityPosition: 'top-right'
  3. Run next dev
  4. devIndicators appear at bottom left even if set buildActivityPosition: 'top-right'

Current vs. Expected behavior

Current

スクリーンショット 2024-08-09 111014

Expected

expected

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP PREEMPT_DYNAMIC Sat Jun 29 07:01:04 UTC 2024
  Available memory (MB): 15881
  Available CPU cores: 8
Binaries:
  Node: 22.5.1
  npm: 10.8.2
  Yarn: N/A
  pnpm: N/A
Relevant Packages:
  next: 15.0.0-canary.110 // Latest available version is detected (15.0.0-canary.110).
  eslint-config-next: N/A
  react: 19.0.0-rc-187dd6a7-20240806
  react-dom: 19.0.0-rc-187dd6a7-20240806
  typescript: N/A
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Developer Experience

Which stage(s) are affected? (Select all that apply)

next dev (local)

Additional context

devIndicators was changed at Move static indicator into dev overlay #68369 and this issue occurred then.

The old devIndicators defined position at below code. https://github.com/vercel/next.js/blob/db153fbcd60d8f1265ec09a63ddcd7a82e9f5a2b/packages/next/src/client/dev/dev-build-watcher.ts#L14-L33

However devIndicators didn't initialize position anymore because delete below code. https://github.com/vercel/next.js/blob/c31793fa3bd7085132fc198bc41e7cadefbdac1f/packages/next/src/client/app-index.tsx#L44-L52

It would be good if dev overlay has initialize position function instead.

taylor111111 commented 2 months ago

Screenshot 2024-08-09 at 13 57 28

khuezy commented 2 months ago

I have a slightly different problem, buildActivity: false but it still shows up during development. Nvm, there's another "appIsrStatus" that needs to be set to false

samcx commented 2 months ago

@Marukome0743 Thank you for submitting an issue!

We will be taking a look at this soon (also, feel free to open a PR if you'd like)!