search

vercel / next.js

The React Framework
https://nextjs.org
MIT License
127.2k stars 27.02k forks source link

Turbopack doesnt support magic comments #71934

Open wesbos opened 3 weeks ago

wesbos commented 3 weeks ago

Link to the code that reproduces this issue

👆🏻

To Reproduce

I'm using dynamic imports with MDX to load in some mdx that lives outside the app dir. The approved method for this is to use dynamic imports so the file and it's images stay inside the module graph.

Each blog post has a folder with the MDX file and the images related to that post. The problem comes when there are other files in the folder, Webpack wants to slurp them all up because of the way dynamic imports work:

So I'm using "magic comments" to exclude the files I don't need:

const { default: MDXContent } = await import(/* webpackExclude: /\.mp4$/ */ `../../../../content/${filePath}`);

These magic comments work in Webpack, RSPack but not Turbopack.

Any plans to support them? Or another way to ignore certain files?

Current vs. Expected behavior

👆🏻

Provide environment information

"next": "15.0.1"

Which area(s) are affected? (Select all that apply)

Turbopack

Which stage(s) are affected? (Select all that apply)

next dev (local), next build (local)

Additional context

No response

github-actions[bot] commented 3 weeks ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

wesbos commented 2 weeks ago

Thanks for reopening!