search

vercel / nextjs-subscription-payments

Clone, deploy, and fully customize a SaaS subscription application with Next.js.
https://subscription-payments.vercel.app/
MIT License
6.08k stars 1.23k forks source link

Convert to use Next.js `app` directory #183

Closed dalkommatt closed 1 year ago

dalkommatt commented 1 year ago

Closes #147

This PR switches data fetching to the server for data that was previously fetched client-side in useUser. As such there is no isLoading state, but I don't feel that it degrades the experience.

Additionally:

vercel[bot] commented 1 year ago

@dalkommatt is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-subscription-payments ❌ Failed (Inspect) May 10, 2023 10:46pm
thorwebdev commented 1 year ago

This is looking awesome, thanks @dalkommatt 💚 Will take a look soon!

georgewritescode commented 1 year ago

Would love to see this implemented in the project - great PR! Added a few suggestions there for the server function, hope it helps. As added at the end of my first comment, I would suggest removing the embedded server function altogether to avoid introducing a new 'alpha' concept into the project & to avoid security risks

dalkommatt commented 1 year ago

Would love to see this implemented in the project - great PR! Added a few suggestions there for the server function, hope it helps. As added at the end of my first comment, I would suggest removing the embedded server function altogether to avoid introducing a new 'alpha' concept into the project & to avoid security risks

I'm not seeing your comments anywhere, can you point me in the right direction?

dalkommatt commented 1 year ago

@dalkommatt , apologies - forgot to submit, here they are :)

Would love to see this implemented in the project - great PR! Added a few suggestions there for the server function, hope it helps. As added at the end of my first comment, I would suggest removing the embedded server function altogether (or moving to separate file) to avoid introducing a new 'alpha' concept into the project & to avoid security risks (includes all the variables above it in the client code so have to be careful with importing server-side code from elsewhere)

Thanks for the suggestions, now I can better implement in my own testing. I agree it will be best to leave it out for now though so it's been removed.