Closed dalkommatt closed 1 year ago
@dalkommatt is attempting to deploy a commit to the Vercel Solutions Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nextjs-subscription-payments | ❌ Failed (Inspect) | May 10, 2023 10:46pm |
This is looking awesome, thanks @dalkommatt 💚 Will take a look soon!
Would love to see this implemented in the project - great PR! Added a few suggestions there for the server function, hope it helps. As added at the end of my first comment, I would suggest removing the embedded server function altogether to avoid introducing a new 'alpha' concept into the project & to avoid security risks
Would love to see this implemented in the project - great PR! Added a few suggestions there for the server function, hope it helps. As added at the end of my first comment, I would suggest removing the embedded server function altogether to avoid introducing a new 'alpha' concept into the project & to avoid security risks
I'm not seeing your comments anywhere, can you point me in the right direction?
@dalkommatt , apologies - forgot to submit, here they are :)
Would love to see this implemented in the project - great PR! Added a few suggestions there for the server function, hope it helps. As added at the end of my first comment, I would suggest removing the embedded server function altogether (or moving to separate file) to avoid introducing a new 'alpha' concept into the project & to avoid security risks (includes all the variables above it in the client code so have to be careful with importing server-side code from elsewhere)
Thanks for the suggestions, now I can better implement in my own testing. I agree it will be best to leave it out for now though so it's been removed.
Closes #147
This PR switches data fetching to the server for data that was previously fetched client-side in useUser. As such there is no
isLoading
state, but I don't feel that it degrades the experience.Additionally: