vercel / nft

Node.js dependency tracing utility
https://npmjs.com/@vercel/nft
MIT License
1.31k stars 136 forks source link

fix: remove `node-pre-gyp` dependency #299

Closed styfle closed 2 years ago

styfle commented 2 years ago

In a previous PR (#206), support for @mapbox/node-pre-gyp was added and the legacy node-pre-gyp was kept around for backwards compatibility.

However, these packages are currently identical besides changing ES5 to ES6 (var => const) should be backwards compatible and safe to drop node-pre-gyp.

This will remove the deprecation warning:

Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future

codecov[bot] commented 2 years ago

Codecov Report

Merging #299 (9cb8ee7) into main (48d684f) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files          13       13           
  Lines        1488     1488           
  Branches      555      555           
=======================================
  Hits         1197     1197           
  Misses        121      121           
  Partials      170      170           
Impacted Files Coverage Δ
src/utils/binary-locators.ts 15.38% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more