vercel / nft

Node.js dependency tracing utility
https://npmjs.com/@vercel/nft
MIT License
1.31k stars 136 forks source link

fix: bump rollup pluginutils version #316

Closed dummdidumm closed 1 year ago

dummdidumm commented 1 year ago

Part of #315

This fixes a bug where attachScopes didn't detect the new scope inside the for loop with shadowed variables before, resulting in later code paths possibly crashing because they expect the dependency to be of type string. No test added because as noted in #315 this doesn't thix that issue (if it even is one).

Bumping the version made a previous workaround of conflicting estree-walker versions unnecessary, but required to bring back a now-deleted type from the package

codecov[bot] commented 1 year ago

Codecov Report

Merging #316 (9c41c50) into main (da5b19e) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files          13       13           
  Lines        1501     1501           
  Branches      557      557           
=======================================
  Hits         1210     1210           
  Misses        121      121           
  Partials      170      170           
Impacted Files Coverage Δ
src/utils/ast-helpers.ts 93.75% <ø> (ø)
src/utils/static-eval.ts 83.17% <ø> (ø)
src/analyze.ts 86.11% <100.00%> (ø)
src/utils/wrappers.ts 74.75% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more