Open cb1kenobi opened 1 year ago
@cb1kenobi This test is passing https://github.com/vercel/nft/actions/runs/6384547761/job/17327429573?pr=364#step:8:6107
Is that because it doesn't set mixedModules: true
?
@styfle Correct. I didn't commit the change to integration.test.js
that enables mixedModules = true
for this test.
When a
.mjs
file is traced, it adds allimport
intodeps
instead ofimports
. Later in the tracing, it treatsdeps
as CJS and it incorrectly resolves the default export for theplaywright-core
package.This regression was introduced by https://github.com/vercel/nft/pull/362, but that PR does fix the issue of CJS files being resolved incorrectly.
I don't know the background, but it seems all
import
s, especially in.mjs
files, should go intoimports
, notdeps
.@styfle can you please advise?
Test failure: