search

vercel / nft

Node.js dependency tracing utility
https://npmjs.com/@vercel/nft
MIT License
1.31k stars 136 forks source link

fix(analyze): node-gyp-build not including zeromq prebuilds #392

Closed eulersson closed 7 months ago

eulersson commented 7 months ago

Three things I want to point out:

  1. In zeromq the way node-gyp-build is called is by passing path.join(__dirname, "..") instead of __dirname to the require("node-gyp-build")(...) call.
  2. In zeromq they use @aminya/node-gyp-build instead of node-gyp-build, particular-li version 4.5.0-aminya.5.
  3. The zeromq version that's recommended for new project is the 6 which is beta according to @aminya https://github.com/zeromq/zeromq.js.

After those changes it resolves OK.

❯ node ./node_modules/@vercel/nft/out/cli.js print ./node_modules/zeromq/lib/index.js
FILELIST:
node_modules/@aminya/node-gyp-build/index.js
node_modules/@aminya/node-gyp-build/package.json
node_modules/zeromq/lib/draft.js
node_modules/zeromq/lib/index.js
node_modules/zeromq/lib/native.js
node_modules/zeromq/lib/util.js
node_modules/zeromq/package.json
node_modules/zeromq/prebuilds/darwin-x64/node.napi.glibc.node <---- It worked!
eulersson commented 7 months ago

I will fix the test havoc ⛈️

aminya commented 7 months ago

@eulersson Thanks for making a fix. Let me know if there is anything to do on the Zeromq side.

eulersson commented 7 months ago

@eulersson Thanks for making a fix. Let me know if there is anything to do on the Zeromq side.

No problem. For now I do not think it will be needed.

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 0.26.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: